[
https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396268#comment-14396268
]
Maryann Xue commented on PHOENIX-1580:
--------------------------------------
I fixed that in my second patch (v4). The earlier mistake was not passing the
order-by and limit to the single query, and that was because I didn't realize
the grammar change. And it certainly had nothing to with union queries. Even
with my first patch, all union tests passed. To understand why, you can study
the QueryCompiler code and meanwhile check to see if there is any place that
would reference those flags you set for the union query at top level. You
should judge if one thing is correct by understanding how everything works and
not by simply looking at if your tests would pass.
> Support UNION ALL
> -----------------
>
> Key: PHOENIX-1580
> URL: https://issues.apache.org/jira/browse/PHOENIX-1580
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Alicia Ying Shu
> Assignee: Maryann Xue
> Attachments: PHOENIX-1580-grammar.patch, PHOENIX-1580-v10.patch,
> PHOENIX-1580-v9.patch, Phoenix-1580-v1.patch, Phoenix-1580-v2.patch,
> Phoenix-1580-v3.patch, Phoenix-1580-v4.patch, Phoenix-1580-v5.patch,
> Phoenix-1580-v6.patch, Phoenix-1580-v7.patch, Phoenix-1580-v8.patch,
> phoenix-1580-v1-wipe.patch, phoenix-1580.patch, unionall-wipe.patch
>
>
> Select * from T1
> UNION ALL
> Select * from T2
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
