[ 
https://issues.apache.org/jira/browse/PHOENIX-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14421481#comment-14421481
 ] 

Hudson commented on PHOENIX-1809:
---------------------------------

FAILURE: Integrated in Phoenix-master #664 (See 
[https://builds.apache.org/job/Phoenix-master/664/])
PHOENIX-1809 Improve explain plan (jtaylor: rev 
c823be992460c4211bce713d7e24a125b108c2b8)
* phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/KeyOnlyIT.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/HashJoinIT.java
* phoenix-core/src/test/java/org/apache/phoenix/query/QueryPlanTest.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryWithLimitIT.java
* phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
* 
phoenix-core/src/main/java/org/apache/phoenix/iterate/MergeSortTopNResultIterator.java
* phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java


> Improve explain plan
> --------------------
>
>                 Key: PHOENIX-1809
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1809
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 5.0.0, 4.4.0
>
>         Attachments: PHOENIX-1809.patch, PHOENIX-1809_v2.patch
>
>
> Two changes:
> 1) We already output the limit information, so it's redundant to display the 
> PageFilter filter. Instead we should skip that filter in ExplainTable when we 
> generate the explain plan - there are about 5 places in the code that need to 
> be changed that expect this in the explain plan.
> 2) Instead of the hacky boolean we pass through MergeSortTopNResultIterator 
> to control the output of the server-side order by/limit, we should output 
> that information in ExplainTable as well. We'd need to pass through the LIMIT 
> information there too. Then the MergeSortTopNResultIterator would only output 
> the CLIENT MERGE SORT step.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to