[ 
https://issues.apache.org/jira/browse/PHOENIX-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485739#comment-14485739
 ] 

James Taylor commented on PHOENIX-1824:
---------------------------------------

We already use @Parameterzied for many IT tests so that, for example, they run 
with and without secondary indexes, with and without salting, etc. I think 
we'll need a different mechanism, though. Might not need to run them all both 
ways.

In general, our IT suite plumbing is in need of some work, in particular for 
when a new orthogonal feature like this is introduced. It'd be nice to be able 
to run all unit tests with the table salted/unsalted, indexed/not indexed 
(mutable global, immutable local, mutable local, immutable global), 
multi-tenant/single-tenant. Both [~samarthjain] and [~gabriel.reid] have good 
ideas in this area. One is that the table name should be generated and unique 
to a test - that way we don't have to delete the table or bring down and up the 
mini cluster (by far the biggest cost in terms of times which makes doing the 
above infeasible until fixed).

> Run all IT's through Query Server
> ---------------------------------
>
>                 Key: PHOENIX-1824
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1824
>             Project: Phoenix
>          Issue Type: Test
>    Affects Versions: 4.4.0
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: 1824.wip.patch
>
>
> Once we have PHOENIX-971 merged, we can increase our confidence in the server 
> by parameterizing our IT suite to run over either driver, or both. This will 
> probably require refactoring the IT suite out of phoenix-core/src/it into a 
> separate module so that module can depend on both phoenix-core and 
> phoenix-server modules.
> This is looking like it will also depend on improvements to Calcite that may 
> not make it into 1.2 release (as RC's for that release have already started).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to