[
https://issues.apache.org/jira/browse/PHOENIX-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Taylor updated PHOENIX-1826:
----------------------------------
Description: We currently traverse the ORDER BY ParseNodes in
TrackOrderPreservingExpressionCompiler to determine if the rows will be ordered
in row key order. This complicates supporting ORDER BY expressions that are an
ordinal position (PHOENIX-1749), since it's a fair bit of code to manufacture a
ParseNode when wildcards are used in the select. We should consider writing
this visitor as an Expression instead and then using ordinal position would be
easy as we could index into the RowProjector to get an Expression. See
ViewWhereExpressionVisitor in CreateTableCompiler for an example. (was: We
currently traverse the ORDER BY ParseNodes in
TrackOrderPreservingExpressionCompiler to determine if the rows will be ordered
in row key order. This complicates supporting ORDER BY expressions that are an
ordinal position (PHOENIX-1749), since it's a fair bit of code to manufacture a
ParseNode when wildcards are used in the select. We should consider writing
this visitor as an Expression instead and then using ordinal position would be
easy as we could index into the RowProjector to get an Expression.)
> Implement TrackOrderPreservingExpressionCompiler as Expression visitor
> instead of ParseNode visitor
> ---------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-1826
> URL: https://issues.apache.org/jira/browse/PHOENIX-1826
> Project: Phoenix
> Issue Type: Task
> Reporter: James Taylor
>
> We currently traverse the ORDER BY ParseNodes in
> TrackOrderPreservingExpressionCompiler to determine if the rows will be
> ordered in row key order. This complicates supporting ORDER BY expressions
> that are an ordinal position (PHOENIX-1749), since it's a fair bit of code to
> manufacture a ParseNode when wildcards are used in the select. We should
> consider writing this visitor as an Expression instead and then using ordinal
> position would be easy as we could index into the RowProjector to get an
> Expression. See ViewWhereExpressionVisitor in CreateTableCompiler for an
> example.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
