[ https://issues.apache.org/jira/browse/PHOENIX-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491276#comment-14491276 ]
James Taylor commented on PHOENIX-1792: --------------------------------------- Please make sure all tests upsert at least two rows (more is better). What if your function always matches, you'd never know? Same advice from last two patches... > Add Week() and Hour() built-ins > ------------------------------- > > Key: PHOENIX-1792 > URL: https://issues.apache.org/jira/browse/PHOENIX-1792 > Project: Phoenix > Issue Type: Improvement > Reporter: Alicia Ying Shu > Assignee: Alicia Ying Shu > Fix For: 5.0.0, 4.4.0 > > Attachments: Phoenix-1792-v1.patch, Phoenix-1792.patch > > > WEEK(date) An integer from 1 to 53 representing the week of the year in date > HOUR(time) An integer from 0 to 23 representing the hour component of time -- This message was sent by Atlassian JIRA (v6.3.4#6332)