[ https://issues.apache.org/jira/browse/PHOENIX-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Taylor resolved PHOENIX-1826. ----------------------------------- Resolution: Fixed Fix Version/s: 4.4.0 5.0.0 > Implement TrackOrderPreservingExpressionCompiler as Expression visitor > instead of ParseNode visitor > --------------------------------------------------------------------------------------------------- > > Key: PHOENIX-1826 > URL: https://issues.apache.org/jira/browse/PHOENIX-1826 > Project: Phoenix > Issue Type: Task > Reporter: James Taylor > Assignee: James Taylor > Fix For: 5.0.0, 4.4.0 > > Attachments: PHOENIX-1826-combined.patch, PHOENIX-1826.patch, > PHOENIX-1826.patch > > > We currently traverse the ORDER BY ParseNodes in > TrackOrderPreservingExpressionCompiler to determine if the rows will be > ordered in row key order. This complicates supporting ORDER BY expressions > that are an ordinal position (PHOENIX-1749), since it's a fair bit of code to > manufacture a ParseNode when wildcards are used in the select. We should > consider writing this visitor as an Expression instead and then using ordinal > position would be easy as we could index into the RowProjector to get an > Expression. See ViewWhereExpressionVisitor in CreateTableCompiler for an > example. -- This message was sent by Atlassian JIRA (v6.3.4#6332)