Github user jmahonin commented on the pull request:

    https://github.com/apache/phoenix/pull/63#issuecomment-92903008
  
    Re: step c, I would lean towards not including either the spark or scala 
library JARs. They are provided by the Spark runtime itself, so I'm not sure it 
makes sense to bundle them within the phoenix assembly JAR. Does that make 
sense to you?
    
    ref:
    https://spark.apache.org/docs/latest/submitting-applications.html
    https://github.com/sbt/sbt-assembly#-provided-configuration
    
    After those, I think the only other runtime dependency not already in the 
all-common-jars file is one for snappy-java, which I'm not sure is explicitly 
needed anymore that we're part of a multi-module build. I will double-check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to