[ 
https://issues.apache.org/jira/browse/PHOENIX-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503992#comment-14503992
 ] 

Lars Hofhansl commented on PHOENIX-1873:
----------------------------------------

These methods are needed by jackson, right? So that's why they need to be there 
and are not referenced by any code.
How should we generally deal with this? Is supressing the warnings the right 
thing? Or should we (somehow) relax the Eclipse settings, maybe just for these 
files?

[~mujtabachohan], you committed this, what do you think?


> Fix compilation errors in Pherf
> -------------------------------
>
>                 Key: PHOENIX-1873
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1873
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Cody Marcel
>         Attachments: PHOENIX-1873.patch
>
>
> Please fix the compilation errors in Pherf. FYI, the default settings for 
> Eclipse can be found in dev/eclipse_prefs_phoenix.epf as described here: 
> http://phoenix.apache.org/contributing.html#Code_conventions
> {code}
> The method writeXML() from the type ConfigurationParserTest is never used 
> locally     ConfigurationParserTest.java    
> /pherf/src/test/java/org/apache/phoenix/pherf   line 141        Java Problem
> The value of the field DataLoader.properties is not used      DataLoader.java 
> /pherf/src/main/java/org/apache/phoenix/pherf/loaddata  line 61 Java Problem
> The value of the field DataLoaderTest.loader is not used      
> DataLoaderTest.java     /pherf/src/test/java/org/apache/phoenix/pherf   line 
> 34 Java Problem
> The value of the field DataLoaderTest.model is not used       
> DataLoaderTest.java     /pherf/src/test/java/org/apache/phoenix/pherf   line 
> 33 Java Problem
> The value of the field QueryExecutor.resultUtil is not used   
> QueryExecutor.java      
> /pherf/src/main/java/org/apache/phoenix/pherf/workload  line 47 Java Problem
> The value of the field Result.type is not used        Result.java     
> /pherf/src/main/java/org/apache/phoenix/pherf/result    line 30 Java Problem
> Type String[] of the last argument to method printRecord(Object...) doesn't 
> exactly match the vararg parameter type. Cast to Object[] to confirm the 
> non-varargs invocation, or pass individual arguments of type Object for a 
> varargs invocation.    CSVResultHandler.java   
> /pherf/src/main/java/org/apache/phoenix/pherf/result/impl       line 126      
>   Java Problem
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to