[
https://issues.apache.org/jira/browse/PHOENIX-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508546#comment-14508546
]
Gabriel Reid commented on PHOENIX-1904:
---------------------------------------
+1 LGTM
> bin scripts use incorrect variable for locating hbase conf
> ----------------------------------------------------------
>
> Key: PHOENIX-1904
> URL: https://issues.apache.org/jira/browse/PHOENIX-1904
> Project: Phoenix
> Issue Type: Bug
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Fix For: 5.0.0, 4.4.0
>
> Attachments: PHOENIX-1904.00.patch, PHOENIX-1904.00.patch,
> PHOENIX-1904.00.patch, PHOENIX-1904.00.patch
>
>
> in bin/phoenix_utils.py, we're building a classpath based on an incorrect
> environment variable. 'HBASE_CONF_PATH' is used:
> https://github.com/apache/phoenix/blob/master/bin/phoenix_utils.py#L68
> While bigtop is registering 'HBASE_CONF_DIR' for us.
> https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/hbase/hbase.default#L17
> There's even a local work-around for this problem in end2endTest.py
> https://github.com/apache/phoenix/blob/master/bin/end2endTest.py#L37
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)