Github user AakashPradeep commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/75#discussion_r28941403
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---
@@ -1144,17 +1144,18 @@ public static PDataType fromLiteral(Object value) {
return null;
}
for (PDataType type : PDataType.values()) {
- if (type.isArrayType()) {
- PhoenixArray arr = (PhoenixArray) value;
- if ((type.getSqlType() == arr.baseType.sqlType +
PDataType.ARRAY_TYPE_BASE)
- && type.getJavaClass().isInstance(value)) {
- return type;
- }
- } else {
- if (type.getJavaClass().isInstance(value)) {
- return type;
- }
- }
+ if (type.isArrayType() &&
type.getJavaClass().isInstance(value)) {
--- End diff --
Default implementation of isArrayType() returns false, hence I have not
modified it. But in ordered list PVarcharArray comes before PJsonDataType and
so value is first testified against PVarcharArraay. Now since PVarcharArray is
ArrayType it gets inside the if() and type cast the value which throws
ClassCastException since value is of type PJsonDataType. After casting the
value, in next if (Line 1150) it validates whether this isInstance() which is
not correct. Instead before casting value we should check whether it is
instance of current type or not to avoid any ClassCastException.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
