[ 
https://issues.apache.org/jira/browse/PHOENIX-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509848#comment-14509848
 ] 

James Taylor commented on PHOENIX-1888:
---------------------------------------

Thanks, [~ndimiduk] - this is really great. Let us know when you feel like it's 
ready for consumption. I think we'll need to outline the new check-in process. 
I think we already have find bugs plugged in (though not invoked like we should 
by default), but as you mentioned, I don't think we have check style. Would be 
good to have both so we can maintain consistency going forward. I'm happy to 
help tidy things up that have drifted off (for example, I've seen a few 2 space 
files creep in).

> [build] add pre-commit scripts
> ------------------------------
>
>                 Key: PHOENIX-1888
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1888
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: 1888.patch
>
>
> Let's get [PreCommit-PHOENIX-Build 
> |https://builds.apache.org/job/PreCommit-PHOENIX-Build/] working.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to