Github user mravi commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/74#discussion_r29023350
--- Diff:
phoenix-hive/src/main/java/org/apache/phoenix/hive/HivePhoenixInputFormat.java
---
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.hive;
+
+import java.io.IOException;
+import java.sql.Connection;
+import java.sql.Statement;
+import java.util.List;
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.io.NullWritable;
+import org.apache.hadoop.io.Text;
+import org.apache.hadoop.mapred.FileSplit;
+import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.RecordReader;
+import org.apache.hadoop.mapred.Reporter;
+import org.apache.hadoop.mapreduce.JobContext;
+import org.apache.hadoop.mapreduce.lib.db.DBWritable;
+import org.apache.phoenix.compile.QueryPlan;
+import org.apache.phoenix.compile.StatementContext;
+import org.apache.phoenix.hive.util.HiveConnectionUtil;
+import org.apache.phoenix.jdbc.PhoenixStatement;
+import org.apache.phoenix.mapreduce.*;
+import org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil;
+import org.apache.phoenix.query.KeyRange;
+import org.apache.phoenix.schema.TableRef;
+import org.apache.phoenix.util.ScanUtil;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.Lists;
+
+
+/**
+* HivePhoenixInputFormat
+* Need to extend the standard PhoenixInputFormat but also implement the
mapred inputFormat for Hive compliance
+*
+* @version 1.0
+* @since 2015-02-08
+*/
+
+public class HivePhoenixInputFormat<T extends DBWritable> extends
org.apache.phoenix.mapreduce.PhoenixInputFormat<T> implements
org.apache.hadoop.mapred.InputFormat<NullWritable, T>{
--- End diff --
How about the idea we have an abstract BasePhoenixInputFormat that provides
the implementation for both the old and the new mapreduce API and provide an
abstract method to convert the KeyRange to a PhoenixInputSplit or
HivePhoenixInputSplit.
On the other hand, if we wanted to completely avoid support for mapred api,
we can push the code in getQueryPlan() and part of generateSplits into a Util
class that way we avoid a lot of code duplication.
@ddraj , @JamesRTaylor What is your recommendation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
