Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/77#discussion_r29098070
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java ---
    @@ -383,6 +448,85 @@ protected TableRef createTableRef(NamedTableNode 
tableNode, boolean updateCacheI
                 return tableRef;
             }
     
    +        @Override
    +        public List<PFunction> getFunctions() {
    +            return functions;
    +        }
    +
    +        protected List<PFunction> createFunctionRef(List<String> 
functionNames, boolean updateCacheImmediately) throws SQLException {
    --- End diff --
    
    Minor nit: is this function overriden somewhere? If not, it could be made 
private


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to