[
https://issues.apache.org/jira/browse/PHOENIX-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513890#comment-14513890
]
Hadoop QA commented on PHOENIX-1856:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12728367/Phoenix-1856_1.patch
against master branch at commit 986b87f374176a3a4595469b09b3f98068a1a63d.
ATTACHMENT ID: 12728367
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 3
warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ "SELECT GUIDE_POSTS_COUNT, REGION_NAME,
GUIDE_POSTS_ROW_COUNT, MIN_KEY, MAX_KEY FROM SYSTEM.STATS WHERE PHYSICAL_NAME='"
+ "SELECT GUIDE_POSTS_COUNT, REGION_NAME, GUIDE_POSTS_ROW_COUNT,
MIN_KEY, MAX_KEY FROM SYSTEM.STATS WHERE PHYSICAL_NAME='"
+ + "GUIDE_POSTS_ROW_COUNT, MIN_KEY, MAX_KEY
FROM SYSTEM.STATS WHERE PHYSICAL_NAME='"
+ "SELECT GUIDE_POSTS_COUNT, REGION_NAME, GUIDE_POSTS_ROW_COUNT,
MIN_KEY, MAX_KEY FROM SYSTEM.STATS WHERE PHYSICAL_NAME='"
+ public GuidePostsInfo(long byteCount, List<byte[]> guidePosts, long
rowCount, byte[] minKey, byte[] maxKey) {
+ Collections.<byte[]> emptyList(), 0l,
HConstants.EMPTY_BYTE_ARRAY, HConstants.EMPTY_BYTE_ARRAY));
+ // Always collect maxKey. 'hasMore' from scanner.next() can be false
with some non-empty results,
+ Collections.<byte[]> emptyList(), 0l,
HConstants.EMPTY_BYTE_ARRAY, HConstants.EMPTY_BYTE_ARRAY));
+ public void addGuidePost(ImmutableBytesPtr cfKey, GuidePostsInfo info,
long byteSize, long timestamp,
+ get.addColumn(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES,
PhoenixDatabaseMetaData.MIN_KEY_BYTES);
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/26//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/26//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/26//console
This message is automatically generated.
> Include min and max row key for each region in stats row
> --------------------------------------------------------
>
> Key: PHOENIX-1856
> URL: https://issues.apache.org/jira/browse/PHOENIX-1856
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: ramkrishna.s.vasudevan
> Attachments: Phoenix-1856_1.patch
>
>
> It'd be useful to record the min and max row key for each region to make it
> easier to filter guideposts through queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
