Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/79#discussion_r29262953
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PArrayDataType.java
---
@@ -543,6 +544,156 @@ private static void writeEndBytes(byte[] array, int
newOffsetArrayPosition, int
Bytes.putByte(array, newOffsetArrayPosition + offsetArrayLength +
byteSize + 2 * Bytes.SIZEOF_INT, header);
}
+ public static boolean prependItemToArray(ImmutableBytesWritable ptr,
int length, int offset, byte[] arrayBytes, PDataType baseType, int arrayLength,
Integer maxLength, SortOrder sortOrder) {
+ int elementLength = maxLength == null ? ptr.getLength() :
maxLength;
+ if (ptr.getLength() == 0) {
+ elementLength = 0;
+ }
+
+ //padding
+ if (elementLength > ptr.getLength()) {
+ baseType.pad(ptr, elementLength, sortOrder);
+ }
+
+ int elementOffset = ptr.getOffset();
+ byte[] elementBytes = ptr.get();
+
+ byte[] newArray;
+ if (!baseType.isFixedWidth()) {
+ int offsetArrayPosition = Bytes.toInt(arrayBytes, offset +
length - Bytes.SIZEOF_INT - Bytes.SIZEOF_INT - Bytes.SIZEOF_BYTE,
Bytes.SIZEOF_INT);
+ int offsetArrayLength = length - offsetArrayPosition -
Bytes.SIZEOF_INT - Bytes.SIZEOF_INT - Bytes.SIZEOF_BYTE;
+ arrayLength = Math.abs(arrayLength);
+
+ //checks whether offset array consists of shorts or integers
+ boolean useInt = offsetArrayLength / arrayLength ==
Bytes.SIZEOF_INT;
+ boolean convertToInt = false;
+
+ int endElementPosition = getOffset(arrayBytes, arrayLength -
1, !useInt, offsetArrayPosition + offset) + elementLength + Bytes.SIZEOF_BYTE;
+
+ int newOffsetArrayPosition;
+ int offsetShift;
+ int firstNonNullElementPosition = 0;
+ int currentPosition = 0;
+ //handle the case where appended element is null
+ if (elementLength == 0) {
+ int nulls = 0;
+ //counts the number of nulls which are already at the
beginning of the array
+ for (int index = 0; index < arrayLength; index++) {
+ int currOffset = getOffset(arrayBytes, index, !useInt,
offsetArrayPosition + offset);
+ if (arrayBytes[offset + currOffset] ==
QueryConstants.SEPARATOR_BYTE) {
+ nulls++;
+ } else {
+ //gets the offset of the first element after nulls
at the beginning
+ firstNonNullElementPosition = currOffset;
+ break;
+ }
+ }
+ nulls++;
+
+ int nMultiplesOver255 = nulls / 255;
+ endElementPosition = getOffset(arrayBytes, arrayLength -
1, !useInt, offsetArrayPosition + offset) + nMultiplesOver255 + 2 *
Bytes.SIZEOF_BYTE;
--- End diff --
Why overwriting endElementPosition - better do this only once where you
want it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
