Just to be clear, I am saying that if the 4.4 RC tarball layout is the same/similar as the previous RC layouts it is not a reason to sink the RC. But for future, we should do the maven assemblies.
Enis On Tue, May 5, 2015 at 4:53 PM, Enis Söztutar <[email protected]> wrote: > I was inquiring the same thing in > https://issues.apache.org/jira/browse/PHOENIX-1945?focusedCommentId=14527077&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14527077 > . > > I think we should get rid of the custom tarball format in dev/make_rc.sh, > and only do maven assembly packaging. Whether this sinks the RC is an open > question. The binary tarball is just for convenience actually. So I am not > sure we need to sink the RC as long as bigtop packaging can take this > tarball and create the binary tarball in the expected layout. > > Enis > > On Tue, May 5, 2015 at 4:23 PM, Nick Dimiduk <[email protected]> wrote: > >> Yeah, I just had a look at the content of the 4.4.0-bin RC. There's no lib >> folder, just jars in the top level. That's different from the bigtop >> installation. This probably sinks the RC. >> >> + Rajesh >> >> On Tue, May 5, 2015 at 4:13 PM, Sergey Belousov < >> [email protected]> >> wrote: >> >> > I will try thank you >> > my question was what would be proper (out of box) structure for the >> > Phoenix client? >> > >> > in tar from what I remember it all jars together and than bin folder. I >> do >> > not think it has lib folder unless assumption is that all jars dumped to >> > hbase/lib >> > On May 5, 2015 6:47 PM, "Nick Dimiduk" <[email protected]> wrote: >> > >> > > Do try my suggestion on the ticket using the `touch` command to create >> > the >> > > missing directory entry. It should fill in the gap for you. >> > > >> > > On Tue, May 5, 2015 at 3:39 PM, Sergey Belousov < >> > [email protected] >> > > > >> > > wrote: >> > > >> > > > Thank you Nick >> > > > I would not even call what we have packaging :) >> > > > >> > > > So what would be proper out of box folder structure for phoenix 4.4 >> > > client >> > > > with sqlline ? >> > > > >> > > > we also switched to HDP 2.2 distribution if that make any difference >> > > > (hopefully not) >> > > > >> > > > thank you >> > > > S >> > > > On May 5, 2015 5:00 PM, "Nick Dimiduk" <[email protected]> wrote: >> > > > >> > > > > Hi Sergey, >> > > > > >> > > > > Nice find. I left a comment over on PHOENIX-1904. From my point of >> > > view, >> > > > > this is a bug raised by your custom packaging and not bad enough >> to >> > > sink >> > > > > the RC -- i.e., the RC should still work "out of the box". Should >> > > > > definitely file a ticket to make the launch scripts more robust in >> > the >> > > > > future though! >> > > > > >> > > > > Thanks for spinning the bits. >> > > > > -n >> > > > > >> > > > > On Tue, May 5, 2015 at 12:39 PM, Sergey Belousov < >> > > > > [email protected]> >> > > > > wrote: >> > > > > >> > > > > > Hello All >> > > > > > >> > > > > > I was trying 4.4 and came across following issue >> > > > > > >> > > > > > We had phoenix-client folder with phoenix-*-client.jar and /bin >> > > folder >> > > > > > under. >> > > > > > Than we used sqlline.py to run our schema creation scripts. >> > > > > > After I updated bin folder from 4.4 and phoenix client with >> > > > > > phoenix-4.4.0-HBase-0.98-client.jar when I try to run sqlline.py >> > > > > script.sql >> > > > > > I am getting following errors: >> > > > > > >> > > > > > Applying _phoenixschema/001_.sql >> > > > > > Traceback (most recent call last): >> > > > > > File "phoenix-client/bin/psql.py", line 27, in <module> >> > > > > > phoenix_utils.setPath() >> > > > > > File "---/phoenix-client/bin/phoenix_utils.py", line 94, in >> > setPath >> > > > > > phoenix_queryserver_jar = findFileInPathWithoutRecursion >> > > > > > (PHOENIX_QUERYSERVER_JAR_PATTERN, os.path.join(current_dir, >> "..", >> > > > "lib")) >> > > > > > File "---/phoenix-client/bin/phoenix_utils.py", line 45, in >> > > > > > findFileInPathWithoutRecursion >> > > > > > files = [f for f in os.listdir(path) if >> > > > os.path.isfile(os.path.join( >> > > > > > path,f))] >> > > > > > OSError: [Errno 2] No such file or directory: >> > > > '---/phoenix-client/bin/../ >> > > > > > lib' >> > > > > > {noformat} >> > > > > > >> > > > > > >> > > > > > Do I miss missing something (probably) ? >> > > > > > What is the upgrade path from 4.3 to 4.4 >> > > > > > Do I need to deploy phoenix-server-4.4.0-HBase-0.98-runnable.jar >> > on >> > > > > server >> > > > > > side even if I do not use query server yet ? >> > > > > > >> > > > > > I guess it related to >> > > > https://issues.apache.org/jira/browse/PHOENIX-1904 >> > > > > > >> > > > > > I do not want to send it to phoenix 4.4 RC0 VOTE thread in a >> hope >> > it >> > > > not >> > > > > > problem with release by my hands :) >> > > > > > >> > > > > > Thank you, >> > > > > > >> > > > > >> > > > >> > > >> > >> > >
