[
https://issues.apache.org/jira/browse/PHOENIX-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536778#comment-14536778
]
Hadoop QA commented on PHOENIX-1958:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12731723/PHOENIX-1958-master.patch
against master branch at commit cd81738b1fbcb5cf19123b2dca8da31f602b9c64.
ATTACHMENT ID: 12731723
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/51//console
This message is automatically generated.
> Minimize memory allocation on new connection
> --------------------------------------------
>
> Key: PHOENIX-1958
> URL: https://issues.apache.org/jira/browse/PHOENIX-1958
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: James Taylor
> Fix For: 5.0.0, 4.4.0
>
> Attachments: PHOENIX-1958-4.x-HBase-0.98.patch,
> PHOENIX-1958-master.patch
>
>
> There's a significant amount of memory allocated when a new connection is
> established solely to create the ReadOnlyProps. Need to figure out a way to
> minimize this. It looks like the majority of memory allocations occur in this
> org.apache.phoenix.util.ReadOnlyProps constructor:
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/util/ReadOnlyProps.java#L61
> Another notable memory allocator is this java.util.HashMap.putAll call:
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java#L192
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
