Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/74#discussion_r29994928
--- Diff:
phoenix-hive/src/main/java/org/apache/phoenix/hive/util/HiveConnectionUtil.java
---
@@ -0,0 +1,161 @@
+/*
+ * Copyright 2010 The Apache Software Foundation
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ *distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you maynot use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicablelaw or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.hive.util;
+
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.SQLException;
+import java.util.Map;
+import java.util.Properties;
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.hive.util.HiveConfigurationUtil;
+
+import com.google.common.base.Preconditions;
+
+/**
+ * Describe your class here.
+ *
+ * @since 138
+ */
+public final class HiveConnectionUtil {
+ private static final Log LOG =
LogFactory.getLog(HiveConnectionUtil.class);
+ private static Connection connection = null;
+
+ /**
+ * Returns the {#link Connection} from Configuration
+ * @param configuration
+ * @return
+ * @throws SQLException
+ */
+ public static Connection getConnection(final Configuration
configuration) throws SQLException {
+ Preconditions.checkNotNull(configuration);
+ if (connection == null) {
+ final Properties props = new Properties();
+ String quorum =
+ configuration
+ .get(HiveConfigurationUtil.ZOOKEEPER_QUORUM !=
null ? HiveConfigurationUtil.ZOOKEEPER_QUORUM
+ :
configuration.get(HConstants.ZOOKEEPER_QUORUM));
+ String znode =
+ configuration
+ .get(HiveConfigurationUtil.ZOOKEEPER_PARENT !=
null ? HiveConfigurationUtil.ZOOKEEPER_PARENT
+ :
configuration.get(HConstants.ZOOKEEPER_ZNODE_PARENT));
+ String port =
+ configuration
+ .get(HiveConfigurationUtil.ZOOKEEPER_PORT !=
null ? HiveConfigurationUtil.ZOOKEEPER_PORT
+ :
configuration.get(HConstants.ZOOKEEPER_CLIENT_PORT));
+ if (!znode.startsWith("/")) {
+ znode = "/" + znode;
+ }
+
+ try {
+ // Not necessary shoud pick it up
+ Class.forName("org.apache.phoenix.jdbc.PhoenixDriver");
+
+ LOG.info("Connection info: " + PhoenixRuntime.JDBC_PROTOCOL
+ + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + quorum
+ + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + port
+ + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + znode);
+
+ final Connection conn =
+
DriverManager.getConnection(PhoenixRuntime.JDBC_PROTOCOL
+ + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR +
quorum
+ + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR +
port
+ + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR +
znode);
+ String autocommit =
configuration.get(HiveConfigurationUtil.AUTOCOMMIT);
+ if (autocommit != null &&
autocommit.equalsIgnoreCase("true")) {
+ conn.setAutoCommit(true);
+ } else {
+ conn.setAutoCommit(false);
+ }
+ connection = conn;
+ } catch (ClassNotFoundException e) {
+ // TODO Auto-generated catch block
+ e.printStackTrace();
+ }
+ }
+ return connection;
+ }
+
+ /**
+ * Returns the {#link Connection} from Configuration
+ * @param configuration
+ * @return
+ * @throws SQLException
+ */
+ //TODO redundant
+ public static Connection getConnection(final Table tbl) throws
SQLException {
+ Preconditions.checkNotNull(tbl);
+ Map<String, String> TblParams = tbl.getParameters();
+ String quorum =
+ TblParams.get(HiveConfigurationUtil.ZOOKEEPER_QUORUM) !=
null ? TblParams.get(
+ HiveConfigurationUtil.ZOOKEEPER_QUORUM).trim()
+ : HiveConfigurationUtil.ZOOKEEPER_QUORUM_DEFAULT;
+ String port =
+ TblParams.get(HiveConfigurationUtil.ZOOKEEPER_PORT) !=
null ? TblParams.get(
+ HiveConfigurationUtil.ZOOKEEPER_PORT).trim()
+ : HiveConfigurationUtil.ZOOKEEPER_PORT_DEFAULT;
+ String znode =
+ TblParams.get(HiveConfigurationUtil.ZOOKEEPER_PARENT) !=
null ? TblParams.get(
+ HiveConfigurationUtil.ZOOKEEPER_PARENT).trim()
+ : HiveConfigurationUtil.ZOOKEEPER_PARENT_DEFAULT;
+ if (!znode.startsWith("/")) {
+ znode = "/" + znode;
+ }
+ try {
+ Class.forName("org.apache.phoenix.jdbc.PhoenixDriver");
+ final Connection conn =
+
DriverManager.getConnection((PhoenixRuntime.JDBC_PROTOCOL
+ + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR +
quorum
+ + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + port
+ + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR +
znode));
+ String autocommit =
TblParams.get(HiveConfigurationUtil.AUTOCOMMIT);
+ if(autocommit!=null && autocommit.equalsIgnoreCase("true")){
+ conn.setAutoCommit(true);
+ }else{
+ conn.setAutoCommit(false);
+ }
+
+ return conn;
+ } catch (ClassNotFoundException e) {
+ e.printStackTrace();
--- End diff --
Here too. Please make sure there aren't other occurrences of swallowing
exceptions. Just throw a SQLException that wraps the ClassNotFoundException.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
