[ 
https://issues.apache.org/jira/browse/PHOENIX-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549777#comment-14549777
 ] 

Jesse Yates commented on PHOENIX-1979:
--------------------------------------

Yeah, I think we can drop those classes. IIRC they were from the generic SI 
framework days, but since no one but phoenix is using it, might as well just 
rip out things that phoenix doesnt use :)

> FamilyOnlyFilter should test for != INCLUDE instead of == SKIP
> --------------------------------------------------------------
>
>                 Key: PHOENIX-1979
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1979
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 5.0.0, 4.3.0, 4.4.0
>
>         Attachments: PHOENIX-1979.patch
>
>
> TestFamilyOnlyFilter wants to confirm that the HBase FamilyFilter filters out 
> cells as expected, but is unnecessarily brittle in that it checks for a 
> specific return hint (SKIP) when it should just be checking that the cell was 
> not included (INCLUDE). This breaks after HBASE-13122, which optimizes the 
> FamilyFilter return hints.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to