[
https://issues.apache.org/jira/browse/PHOENIX-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553509#comment-14553509
]
Rajeshbabu Chintaguntla commented on PHOENIX-1982:
--------------------------------------------------
[~jamestaylor]
Thanks for review. I have committed the patch after addressing the comment.
bq. Declaring a default value is orthogonal to whether it's a constant or not,
so we should change this.
We can provide default value irrespective of it's constant it or not. The
syntax I have written for func argument was wrong. I have changed it. see
http://phoenix.apache.org/language/index.html#func_argument.
bq. Default, min, and max values should not require quotes around it. You
should be able to specify them as any other literal in a SQL statement (i.e.
quoted if it's a string, not quoted for numbers, date literals should be ok).
In the built-in function annotations these values are accepted as strings only.
Before validating with function arguments the string will be converted to it's
type. Followed the same here. But we can change it. I will raise JIRA for this.
[~devaraj]
Added the notes for cleanup as well.
Thanks.
> Documentation for UDF support
> -----------------------------
>
> Key: PHOENIX-1982
> URL: https://issues.apache.org/jira/browse/PHOENIX-1982
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.4.0
>
> Attachments: PHOENIX-1982.patch, PHOENIX-1982_v2.patch,
> create_function.csv
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
