Makes sense. +1 for cutting the RC from the 4.4 release tag. So in your above plan, I would change step 3 into: (3) Create the 4.4-branch from 4.4.0-HBase-1.0 tag
Then we can commit PHOENIX-1763 and PHOENIX-1681 to 4.4-HBase-1.1, 4.x-HBase-1.1 and master. For Phoenix master branch, and 4.5 releases, I think we can drop HBase-1.0 support if we think that there is a lot of overhead. HBase-1.1 is rolling upgradable and compatible with 1.0, so users should not be stuck with it for a long time. it is a matter of overhead of keeping one extra branch and release vs whether we would want to support Hbase-1.0 users for 4.5+. Just my 2 cents. Enis On Thu, May 21, 2015 at 5:39 PM, [email protected] < [email protected]> wrote: > Makes sense Nick. Cut the new branch from 4.4.0-HBase-1.0 tag. > > Thanks, > Rajeshbabu. > > On Fri, May 22, 2015 at 5:58 AM, Nick Dimiduk <[email protected]> wrote: > > > This looks good except for (1) branch should be cut from the > > 4.4.0-HBase-1.0 tag. That way 4.4.0 will be feature-identical across all > > releases. Then we'll need to go back over what's landed on 4.x-HBase-1.0 > > since 4.4.0 was released and bring forward any patches, so that all 3 > > branches are aligned for 4.4.1. > > > > Make sense? > > > > On Thu, May 21, 2015 at 1:35 PM, [email protected] < > > [email protected]> wrote: > > > > > Thanks James. Sure I will run it also. > > > > > > Here is my plan for the release: > > > > > > 1) create the 4.x-HBase-1.1 branch from latest 4.x-HBase-1.0 > > > 2) change the hbase version to 1.1.0 and commit PHOENIX-1793 > > > 3) Setup jenkins for the branch to run the test suite. > > > 3) cut rc from 4.x-HBase-1.1 > > > 4) before vote is going to pass create 4.4-HBase-1.1 branch for 4.4.x > bug > > > fix releases. > > > > > > I > > > > > > Thanks, > > > Rajeshbabu. > > > > > > > > > On Thu, May 21, 2015 at 9:52 PM, James Taylor <[email protected]> > > > wrote: > > > > > > > Hi Rajeshbabu, > > > > Sounds good. Probably a good idea to run our perf regression suite to > > > > get an idea of performance too. I'm fine with a release, though. > > > > Thanks, > > > > James > > > > > > > > On Thu, May 21, 2015 at 6:09 AM, [email protected] > > > > <[email protected]> wrote: > > > > > James, > > > > > > > > > > I have installed HBase 1.1.0 with phoenix-4.4.0-HBase-1.0 rc1 + > > > > > PHOENIX-1763 patch at server side. Created tables,indexes,uploaded > > data > > > > > with performance script from the new client and performed > > reads/writes > > > > from > > > > > all old clients of versions 4.1.0,4.2.2 and 4.3.1. No issues found. > > > > > > > > > > So I feel we can release with HBase-1.1.0. Running test suite and > > seems > > > > > fine. > > > > > > > > > > Thanks, > > > > > Rajeshbabu. > > > > > > > > > > > > > > > On Wed, May 20, 2015 at 7:05 AM, [email protected] < > > > > > [email protected]> wrote: > > > > > > > > > >> James, > > > > >> > > > > >> bq. Will older Phoenix 4.x clients work with the new Phoenix 4.4 > > > clients > > > > >> against an HBase 1.1 running Phoenix? > > > > >> Mostly they should work. I will quickly check this today. > > > > >> > > > > >> bq. Has Andy's patch already been applied for using > > > > >> the new RS interfaces? > > > > >> The patch at PHOENIX-1763 has required changes after new RS > > interface > > > > >> changes. > > > > >> > > > > >> Thanks, > > > > >> Rajeshbabu > > > > >> > > > > >> On Tue, May 19, 2015 at 11:32 PM, James Taylor < > > > [email protected]> > > > > >> wrote: > > > > >> > > > > >>> Will older Phoenix 4.x clients work with the new Phoenix 4.4 > > clients > > > > >>> against an HBase 1.1 running Phoenix? If no, we'll need to > release > > > > >>> this in a 5.0 version. Has Andy's patch already been applied for > > > using > > > > >>> the new RS interfaces? > > > > >>> > > > > >>> Thanks, > > > > >>> James > > > > >>> > > > > >>> On Tue, May 19, 2015 at 10:30 AM, [email protected] > > > > >>> <[email protected]> wrote: > > > > >>> > Hi, > > > > >>> > > > > > >>> > Already HBase-1.1.0 released and we already have patch to > support > > > > with > > > > >>> > it(PHOENIX-1763). I feel we can release 4.4.0 with HBase-1.1.0 > as > > > > well. > > > > >>> > > > > > >>> > What do you guys say? > > > > >>> > > > > > >>> > Thanks, > > > > >>> > Rajeshbabu. > > > > >>> > > > > >> > > > > >> > > > > > > > > > >
