[ 
https://issues.apache.org/jira/browse/PHOENIX-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555461#comment-14555461
 ] 

Enis Soztutar commented on PHOENIX-1980:
----------------------------------------

getUrl() changes looks right. QueryUtil.getConnectionUrl() now does the right 
thing. 

bq. +            logger.info("Found quorum: " + quorum + ":" + znode);
Maybe debug. No biggie. 

bq. +        if (cmdLine.hasOption(ZK_QUORUM_OPT.getOpt())) {
Previously -z meant that you can only pass the zookeeper quorum (not port and 
znode parent from my understanding). If that is not the case, this logic seems 
correct. If that is the case, then why don't we still do the same thing by just 
setting the conf value and let the   QueryUtil.getConnectionUrl() deal with 
constructing the JDBC string? 

For the remove tests, maybe we can add a simple test for 
QueryUtil.getConnectionUrl() checking for all quorum, port and znode parent. 

> CsvBulkLoad cannot load hbase-site.xml from classpath
> -----------------------------------------------------
>
>                 Key: PHOENIX-1980
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1980
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>             Fix For: 5.0.0, 4.5.0
>
>         Attachments: 1980.patch, PHOENIX-1980.addendum.00.patch
>
>
> When I launch a job using a distributed cluster where hbase-site.xml is 
> provided in {{HADOOP_CLASSPATH}} instead of providing --zookeeper, I see 
> errors showing "localhost:2181/hbase" is the target connection, where I would 
> expect "<hostname>:2181/hbase-unsecure".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to