[ 
https://issues.apache.org/jira/browse/PHOENIX-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Samarth Jain updated PHOENIX-1504:
----------------------------------
    Attachment: PHOENIX-1504_v2.patch

Updated patch. 
I added a test AlterTableIT#testChangingPKOfBaseTableChangesPKForAllViews that 
verifies that adding a PK column to the base table ends up propagating as a PK 
column for the child views too. 

bq. Any reason not to pass only List<Mutation>tableMetadata to 
addRowsToChildViews and just add the new metadata rows in-place (iterating only 
up to the the original size)?

I am not sure I understood this particular comment [~jamestaylor]. All the 
other params are needed for addRowsToChildViews.

> Support adding column to a table that has views
> -----------------------------------------------
>
>                 Key: PHOENIX-1504
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1504
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: Samarth Jain
>             Fix For: 5.0.0, 4.5.0
>
>         Attachments: PHOENIX-1504-wip.patch, PHOENIX-1504.patch, 
> PHOENIX-1504_v2.patch
>
>
> We currently disallow any schema modifications to a table that has views. We 
> should relax that constraint and push the schema change as necessary out to 
> all views.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to