Github user codymarcel commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/89#discussion_r32766179
  
    --- Diff: 
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java ---
    @@ -135,10 +154,7 @@ public synchronized boolean shouldStop() {
             return shouldStop;
         }
     
    -    public synchronized void stop() {
    -        this.shouldStop = true;
    -    }
    -
    +    @SuppressWarnings("unused")
    --- End diff --
    
    I found it useful for testing and debugging. I just didn't leave any of the 
calling code in. I didn't want to have to re-add it later. I can remove it you 
don't like it though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to