Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/89#discussion_r32848394
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/QuerySetResult.java
---
@@ -18,31 +18,30 @@
package org.apache.phoenix.pherf.result;
+import org.apache.phoenix.pherf.configuration.QuerySet;
+
import java.util.ArrayList;
import java.util.List;
-import org.apache.phoenix.pherf.configuration.QuerySet;
-
public class QuerySetResult extends QuerySet {
-
- private List<QueryResult> queryResults = new ArrayList<QueryResult>();
-
- public QuerySetResult(QuerySet querySet) {
- this.setConcurrency(querySet.getConcurrency());
- this.setNumberOfExecutions(querySet.getNumberOfExecutions());
-
this.setExecutionDurationInMs(querySet.getExecutionDurationInMs());
- this.setExecutionType(querySet.getExecutionType());
- }
-
- public QuerySetResult() {
- }
-
- public List<QueryResult> getQueryResults() {
- return queryResults;
- }
-
- @SuppressWarnings("unused")
- public void setQueryResults(List<QueryResult> queryResults) {
- this.queryResults = queryResults;
- }
+
+ private List<QueryResult> queryResults = new ArrayList<QueryResult>();
+
+ public QuerySetResult(QuerySet querySet) {
+ this.setConcurrency(querySet.getConcurrency());
+ this.setNumberOfExecutions(querySet.getNumberOfExecutions());
+ this.setExecutionDurationInMs(querySet.getExecutionDurationInMs());
+ this.setExecutionType(querySet.getExecutionType());
+ }
+
+ public QuerySetResult() {
+ }
+
+ public List<QueryResult> getQueryResults() {
+ return queryResults;
+ }
+
+ @SuppressWarnings("unused") public void
setQueryResults(List<QueryResult> queryResults) {
--- End diff --
I would make queryResults final and remove the method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
