[
https://issues.apache.org/jira/browse/PHOENIX-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajeshbabu Chintaguntla updated PHOENIX-1889:
---------------------------------------------
Attachment: PHOENIX-1889_v2.patch
[~jamestaylor] Thanks for the review. Handled the comments in this patch.
bq. It should match the way we deal with other metadata in that we should issue
the delete based on two factors:
I think other cases we are -1'ing for the client time stamp. But in case of
replace delete timestamp should (clienttimestamp -1) or (serverside timestamp
-1) because delete over put have higher priority with same timestamp. Handled
this in the patch.
bq. Also, how are we handling the case where the same jar name is used? This
will be pretty typical, I suspect, especially using this new CREATE OR REPLACE
syntax. Since the old jar cannot be unloaded, can we detect this and give an
error?
This we can leave it to user because there are scenarios like initially class
name might given wrong and want correct as part of replace then we need not
unload the jar. If he change any thing better to give upload the jar with
different name and use the same in create or replace statement.
bq. I got UNALLOWED_USER_DEFINED_FUNCTIONS exception: "User defined functions
are configured to not be allowed. To allow configure...". We really should
throw a FUNCTION_UNDEFINED exception instead.
Throwing function not found exception in this case and handled in this patch.
> Support alter/replace and drop functions
> ----------------------------------------
>
> Key: PHOENIX-1889
> URL: https://issues.apache.org/jira/browse/PHOENIX-1889
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 5.0.0, 4.5.0, 4.4.1
>
> Attachments: PHOENIX-1889.patch, PHOENIX-1889_v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
