[
https://issues.apache.org/jira/browse/PHOENIX-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619757#comment-14619757
]
ASF GitHub Bot commented on PHOENIX-978:
----------------------------------------
Github user elilevine commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/97#discussion_r34219079
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java ---
@@ -2179,7 +2176,7 @@ public void
testAddExistingViewPkColumnToBaseTableWithViews() throws Exception {
assertEquals(rs.getString(1), "view1");
assertEquals(rs.getInt(2), 12);
assertEquals(rs.getInt(3), 13);
- assertEquals(rs.getInt(4), 14);
+ assertEquals(rs.getBigDecimal(4).intValue(), 14);
--- End diff --
Had to make this change, otherwise was getting BigDecimal rounding errors.
> Allow views to extend base table's PK (only if last PK column is fixed length)
> ------------------------------------------------------------------------------
>
> Key: PHOENIX-978
> URL: https://issues.apache.org/jira/browse/PHOENIX-978
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 3.0.0, 4.0.0
> Reporter: Eli Levine
> Assignee: Eli Levine
> Fix For: 5.0.0, 4.5.0
>
> Attachments: PHOENIX-978.diff
>
>
> CREATE VIEW syntax currently disallows PK constraint to be defined. As a
> result views and tenant-specific tables created using CREATE VIEW
> automatically inherit their base table's PK with no way to extend it.
> Base tables should be allowed to be created with a minimum of PK columns to
> support views, and views to extend PKs as desired. This would allow a single
> base table to support a heterogeneous set of views on top of it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
