Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/98#discussion_r34330056
--- Diff:
phoenix-pig/src/it/java/org/apache/phoenix/pig/udf/ReserveNSequenceTestIT.java
---
@@ -0,0 +1,284 @@
+/**
+ *
+ */
+package org.apache.phoenix.pig.udf;
+
+import static org.apache.phoenix.query.BaseTest.setUpConfigForMiniCluster;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import java.io.IOException;
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.Properties;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.phoenix.end2end.NeedsOwnMiniClusterTest;
+import org.apache.phoenix.jdbc.PhoenixDriver;
+import org.apache.phoenix.util.PhoenixRuntime;
+import org.apache.phoenix.util.PropertiesUtil;
+import org.apache.phoenix.util.TestUtil;
+import org.apache.pig.data.Tuple;
+import org.apache.pig.data.TupleFactory;
+import org.apache.pig.impl.util.UDFContext;
+import org.junit.After;
+import org.junit.AfterClass;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.ExpectedException;
+
+/**
+ * Test class to run all the Pig Sequence UDF integration tests against a
virtual map reduce cluster.
+ */
+@Category(NeedsOwnMiniClusterTest.class)
+public class ReserveNSequenceTestIT {
--- End diff --
Minor item: please take at Ravi's latest changes for BaseHBaseManagedTimeIT
[here](https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commit;h=984e62223c8aa507e9c044cecfc7fc92ffa42522).
It'd be good if you did that as well - it's easier to manage tests that derive
from our base classes as the framework changes. Also, they run faster if you
don't need to spin up your own cluster for each test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
