[
https://issues.apache.org/jira/browse/PHOENIX-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628382#comment-14628382
]
ravi commented on PHOENIX-2116:
-------------------------------
[~jmahonin] The patch looks good. Minor changes if you can make
a) Move the newly added test method to test folder rather than it as its not an
integration test.
b) Create Mock classes of the Sink and custom serializer to confirm if the
initialize and other call back methods are being invoked when you call start.
> phoenix-flume: Sink/Serializer should be extendable
> ---------------------------------------------------
>
> Key: PHOENIX-2116
> URL: https://issues.apache.org/jira/browse/PHOENIX-2116
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.5.0, 4.4.1
> Reporter: Josh Mahonin
> Assignee: Josh Mahonin
> Attachments: PHOENIX-2116.patch
>
>
> When using flume, often times custom serializers are necessary to transform
> data before sending to a sink. The existing Phoenix implementation however
> makes it difficult to extend and add new functionality.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
