[
https://issues.apache.org/jira/browse/PHOENIX-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635800#comment-14635800
]
James Taylor commented on PHOENIX-2088:
---------------------------------------
Would it be ok to release with Thomas' patch, but without any additional Spark
integration work, [~jmahonin]? Perhaps you'll need to stick with your earlier
patch, [~tdsilva]? Or does that cause Spark breakages as well?
Would another alternative be that [~tdsilva] do the additional work you're
talking about and then you could review it, [~jmahonin]?
> Prevent splitting and recombining select expressions for MR integration
> -----------------------------------------------------------------------
>
> Key: PHOENIX-2088
> URL: https://issues.apache.org/jira/browse/PHOENIX-2088
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Thomas D'Silva
> Attachments: PHOENIX-2088-4.4-HBase-0.98-v2.patch,
> PHOENIX-2088-4.4-HBase-0.98.patch, PHOENIX-2088-pig.patch,
> PHOENIX-2088-wip-v2.patch, PHOENIX-2088-wip-v3.patch, PHOENIX-2088-wip.patch
>
>
> We currently send in the select expressions for the MR integration with a
> delimiter separated string, split based on the delimiter, and then recombine
> again using a comma separator. This is problematic because the delimiter
> character may appear in a select expression, thus breaking this logic.
> Instead, we should use a comma as the delimiter and avoid splitting and
> recombining as it's not necessary in that case. Instead, the entire string
> can be used as-is in that case to form the select expressions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
