[ 
https://issues.apache.org/jira/browse/PHOENIX-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas D'Silva updated PHOENIX-2088:
------------------------------------
    Attachment: PHOENIX-2088-4.4-HBase-0.98-v3.patch

[~jmahonin] 

ColumnInfoToStringEncoderDecoder encode() does not return a serialized string 
anymore. It serializes the list of column infos directly into the passed 
configuration object. 
I added your changes  to instantiate a new Configuration and ColumnInfo 
metadata list on a per-partition basis since we can't use a serialized string. 
and the spark tests pass.

I had tried setting using ColumnInfoToStringEncoderDecoder.encode to serialize 
the column info metadata into the configuration object and then tried called 
ColumnInfoToStringEncoderDecoder.decode in data.mapPartitions (in 
ProductRDDFunctions and DataFrameFunctions) but this did not work. 

> Prevent splitting and recombining select expressions for MR integration
> -----------------------------------------------------------------------
>
>                 Key: PHOENIX-2088
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2088
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>         Attachments: PHOENIX-2088-4.4-HBase-0.98-v2.patch, 
> PHOENIX-2088-4.4-HBase-0.98-v3.patch, PHOENIX-2088-4.4-HBase-0.98.patch, 
> PHOENIX-2088-pig.patch, PHOENIX-2088-wip-v2.patch, PHOENIX-2088-wip-v3.patch, 
> PHOENIX-2088-wip.patch
>
>
> We currently send in the select expressions for the MR integration with a 
> delimiter separated string, split based on the delimiter, and then recombine 
> again using a comma separator. This is problematic because the delimiter 
> character may appear in a select expression, thus breaking this logic. 
> Instead, we should use a comma as the delimiter and avoid splitting and 
> recombining as it's not necessary in that case. Instead, the entire string 
> can be used as-is in that case to form the select expressions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to