Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/101#discussion_r35459820
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/JSONOperationT.java ---
    @@ -0,0 +1,285 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.phoenix.end2end;
    +
    +import java.sql.Connection;
    +import java.sql.DriverManager;
    +import java.sql.PreparedStatement;
    +import java.sql.ResultSet;
    +import java.sql.SQLException;
    +import java.util.Properties;
    +
    +import org.apache.phoenix.util.PropertiesUtil;
    +
    +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES;
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertFalse;
    +import static org.junit.Assert.assertTrue;
    +
    +import org.junit.Test;
    +
    +public class JSONOperationT extends BaseHBaseManagedTimeIT{
    +   private String json = "{\"k1\":\"val\","                +"\"k2\":true," 
        +"\"k3\":2 ,"           +"\"k4\":2.5 "+
    +                           ",\"k5\":[1,\"val2\",false,3.5]"+
    +                           
",\"k6\":{\"nestk1\":\"nestval\",\"nestk2\":77,\"nestk3\":2.1,\"nestk4\":[9,8.4,\"nestarrayval\"]}}";
    +   @Test
    +    public void testJsonPointAsElementForTypeInteger() throws Exception {
    +        String selectQuery = "SELECT col1 FROM testJson WHERE col1 -> 'k3' 
= 2";
    +        String pk = "valueOne";
    +        Connection conn = getConnection();
    +        try {
    +
    +            createTableAndUpsertRecord(json, pk, conn);
    +
    +            PreparedStatement stmt = conn.prepareStatement(selectQuery);
    +            ResultSet rs = stmt.executeQuery();
    +            assertTrue(rs.next());
    +            assertEquals("Json data read from DB is not as expected for 
query: <" + selectQuery
    +                    + ">", json, rs.getString(1));
    +            assertFalse(rs.next());
    +
    +        } finally {
    +            conn.close();
    +        }
    +    }
    +   @Test
    +    public void testJsonPointAsElementForTypeFloat() throws Exception {
    +        String selectQuery = "SELECT col1 FROM testJson WHERE col1 -> 'k4' 
= 2.5";
    +        String pk = "valueOne";
    +        Connection conn = getConnection();
    +        try {
    +
    +            createTableAndUpsertRecord(json, pk, conn);
    +
    +            PreparedStatement stmt = conn.prepareStatement(selectQuery);
    +            ResultSet rs = stmt.executeQuery();
    +            assertTrue(rs.next());
    +            assertEquals("Json data read from DB is not as expected for 
query: <" + selectQuery
    +                    + ">", json, rs.getString(1));
    +            assertFalse(rs.next());
    +
    +        } finally {
    +            conn.close();
    +        }
    +    }
    +   @Test
    +    public void testJsonPointAsElementForTypeVarchar() throws Exception {
    +        String selectQuery = "SELECT col1 FROM testJson WHERE col1 -> 'k1' 
LIKE 'val'";
    +        String pk = "valueOne";
    +        Connection conn = getConnection();
    +        try {
    +
    +            createTableAndUpsertRecord(json, pk, conn);
    +
    +            PreparedStatement stmt = conn.prepareStatement(selectQuery);
    +            ResultSet rs = stmt.executeQuery();
    +            assertTrue(rs.next());
    +            assertEquals("Json data read from DB is not as expected for 
query: <" + selectQuery
    +                    + ">", json, rs.getString(1));
    +            assertFalse(rs.next());
    +
    +        } finally {
    +            conn.close();
    +        }
    +    }
    +   @Test
    +    public void testJsonPointAsText() throws Exception {
    --- End diff --
    
    Rename to testGetJsonFieldAsTextByKey


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to