Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/101#discussion_r35595085
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java
---
@@ -200,12 +224,12 @@ public Expression visitLeave(ComparisonParseNode
node, List<Expression> children
Expression lhsExpr = children.get(0);
Expression rhsExpr = children.get(1);
PDataType dataTypeOfLHSExpr = lhsExpr.getDataType();
- if (dataTypeOfLHSExpr != null &&
!dataTypeOfLHSExpr.isEqualitySupported()) {
+ if (!(lhsExpr instanceof BaseJSONExpression)&& dataTypeOfLHSExpr
!= null && !dataTypeOfLHSExpr.isEqualitySupported()) {
--- End diff --
We do not support comparison (=,!=,<,>,<=,>=) of PJson data type.
PDataType.isEqualitySupported() is false for PJson, so you do not need this
check can you remove it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
