Github user elilevine commented on the pull request:
https://github.com/apache/phoenix/pull/104#issuecomment-128830531
Good stuff, @JeffreyLyonsD2L. Added a few questions and comments to the PR.
There is one more issue that it not tackled here that we need to at least
discuss IMHO. Phoenix's metadata tables, such as SYSTEM.CATALOG lead with
TENANT_ID VARCHAR column (take a look in QueryConstants.java). This works well
in a world where all multi-tenant tables can only have VARCHAR tenant id
columns. Your changes introduce the possibility that different multi-tenant
tables will have different types of tenant id columns.
What's the right solution here? The right solution is probably changing
TENANT_ID column type to BINARY in system tables. But that will make upgrades
for existing clusters a pain. Leave them as VARCHAR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
