[
https://issues.apache.org/jira/browse/PHOENIX-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708508#comment-14708508
]
ASF GitHub Bot commented on PHOENIX-2196:
-----------------------------------------
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/114#issuecomment-133910608
Yes, I think that would work. We'd need unit tests around this too, please.
The function we go through to normalize identifier/column references is
SchemaUtil.normalizeIdentifier(String identifier). Here's a SQL example (which
would work fine):
{code}
CREATE TABLE "t" (id VARCHAR PRIMARY KEY, "v" VARCHAR);
UPSERT INTO "t" (ID, "v") VALUES ('a','b');
SELECT ID, "v" FROM "t";
SELECT id, "v" FROM "t";
{code}
Would you have some cycles to review this pull, @jmahonin?
> phoenix-spark should automatically convert DataFrame field names to all caps
> ----------------------------------------------------------------------------
>
> Key: PHOENIX-2196
> URL: https://issues.apache.org/jira/browse/PHOENIX-2196
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Randy Gelhausen
> Priority: Minor
>
> phoenix-spark will fail to save a DF into a Phoenix table if the DataFrame's
> fields are not all capitalized. Since Phoenix internally capitalizes all
> column names, the DataFrame.save method should automatically capitalize DF
> field names as a convenience to the end user.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
