[
https://issues.apache.org/jira/browse/PHOENIX-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726191#comment-14726191
]
ASF GitHub Bot commented on PHOENIX-2182:
-----------------------------------------
Github user codymarcel commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/115#discussion_r38472365
--- Diff:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/ResultUtil.java ---
@@ -147,9 +147,9 @@ public String getSuffix() {
if (null == FILE_SUFFIX) {
Date date = new Date();
Format formatter = new SimpleDateFormat("YYYY-MM-dd_hh-mm-ss");
- FILE_SUFFIX = "_" + formatter.format(date);
+ FILE_SUFFIX = formatter.format(date);
--- End diff --
Should you call setFileSuffix()?
> Pherf - Add ability to compare of run(s) and generate warning if performance
> degrades beyond set threshold
> ----------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-2182
> URL: https://issues.apache.org/jira/browse/PHOENIX-2182
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Mujtaba Chohan
> Assignee: Mujtaba Chohan
> Attachments: PHOENIX-2182.patch
>
>
> Add ability to compare of run(s) and generate warning if performance degrades
> beyond set threshold. This would also need that runs can be labeled for known
> baselines.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
