[ 
https://issues.apache.org/jira/browse/PHOENIX-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729195#comment-14729195
 ] 

Josh Mahonin commented on PHOENIX-2196:
---------------------------------------

Oh, yeah that's definitely a gap with the table name normalization. I'm OK with 
including it in this JIRA since it's pretty similar issue, so we might as well 
do it in one shot.

I think all we need is to invoke one of the SchemaUtil helper functions to 
normalize the table name, and handle schema names as well:
https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java

I don't think I'll be able to get to it before Tuesday at the earliest. If you 
have time to tackle it before then, I can review. I think all we'd need is that 
new normalize call before the following line, and a few unit tests to validate 
it:
https://github.com/apache/phoenix/blob/master/phoenix-spark/src/main/scala/org/apache/phoenix/spark/PhoenixRDD.scala#L73

> phoenix-spark should automatically convert DataFrame field names to all caps
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-2196
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2196
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Randy Gelhausen
>            Assignee: Josh Mahonin
>            Priority: Minor
>         Attachments: PHOENIX-2196.patch
>
>
> phoenix-spark will fail to save a DF into a Phoenix table if the DataFrame's 
> fields are not all capitalized. Since Phoenix internally capitalizes all 
> column names, the DataFrame.save method should automatically capitalize DF 
> field names as a convenience to the end user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to