[ 
https://issues.apache.org/jira/browse/PHOENIX-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746605#comment-14746605
 ] 

James Taylor commented on PHOENIX-1824:
---------------------------------------

For connection properties, I meant the Properties instance passed through the 
DriverManager.getConnection(url, props). I assume these properties and the url 
get passed through to the query server. We'd just want to run some tests to 
make sure that none of them get "dropped" along the way. We allow some 
properties to be passed though the URL (CurrentSCN, TenantId, AutoCommit, and 
Consistency are the ones I know about) and any property to be passed through 
the Properties object. The properties are just key/value pairs, so hopefully 
this is black box as far as Avatica is concerned. Making sure the URL doesn't 
lose anything is hopefully not too bad either, but might be more error prone. 
FWIW, Phoenix can operate fine if everything comes through the Properties 
instead of on the URL.

For testing of this, you can run some tests where you specify a CurrentSCN (see 
PointInTimeQueryIT) or TenantId property (see TenantSpecificTablesDMLIT) in the 
URL.

> Run all IT's through Query Server
> ---------------------------------
>
>                 Key: PHOENIX-1824
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1824
>             Project: Phoenix
>          Issue Type: Test
>    Affects Versions: 4.4.0
>            Reporter: Nick Dimiduk
>            Assignee: Josh Elser
>         Attachments: 1824.wip.patch
>
>
> Once we have PHOENIX-971 merged, we can increase our confidence in the server 
> by parameterizing our IT suite to run over either driver, or both. This will 
> probably require refactoring the IT suite out of phoenix-core/src/it into a 
> separate module so that module can depend on both phoenix-core and 
> phoenix-server modules.
> This is looking like it will also depend on improvements to Calcite that may 
> not make it into 1.2 release (as RC's for that release have already started).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to