Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/117#issuecomment-145189319
Thanks for the patch, @d9liang - I reviewed and left you some minor
feedback. Overall, it looks very good. One other thing to check (and add tests
for) is other code paths that insert data: namely UPSERT SELECT (on client-side
and server-side) and CSV bulk load (which goes through a similar code path as
UPSERT VALUES, so you might already be covered there, not sure). This would
ensure that we're consistently truncating fixed width types in all cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
