[
https://issues.apache.org/jira/browse/PHOENIX-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959862#comment-14959862
]
James Taylor commented on PHOENIX-2284:
---------------------------------------
+1 with one minor fix-on-commit suggestion:
{code}
+ this.returnSequenceValues =
config.getBoolean(QueryServices.RETURN_SEQUENCE_VALUES, false);
{code}
- Change the hard coded false to a new boolean
QueryServicesOptions.DEFAULT_RETURN_SEQUENCE_VALUES with a value of false.
- Change name of QueryServices.RETURN_SEQUENCE_VALUES to
QueryServices.RETURN_SEQUENCE_VALUES_ATTRIB.
> Remove call to returnAllSequences when connection count drop to zero
> --------------------------------------------------------------------
>
> Key: PHOENIX-2284
> URL: https://issues.apache.org/jira/browse/PHOENIX-2284
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.5.0
> Reporter: Brian Esserlieu
> Assignee: Thomas D'Silva
> Fix For: 4.6.0
>
> Attachments: PHOENIX-2284, PHOENIX-2284-v2
>
>
> returnAllSequences is called in ConnectionQueryServices.close from
> PhoenixDriver. It is not required to return sequences when the open
> connection count drops to zero, since a client may open another connection
> soon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
