Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/124#issuecomment-150397877
Thanks for the pull request, @navis. A couple of minor comments, but
overall it looks great. FYI, our PDataType class is stateless (it was an enum
originally), so we currently access maxLength/precision and scale through the
PDatum interface (from which PColumn and Expression are derived). Now that
PDataType is no longer an enum, it might be nice to allow instantiation with
maxLength and scale provided at construction time. Please file a JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
