[ 
https://issues.apache.org/jira/browse/PHOENIX-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970908#comment-14970908
 ] 

ASF GitHub Bot commented on PHOENIX-2257:
-----------------------------------------

Github user maryannxue commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/120#discussion_r42860245
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java ---
    @@ -313,21 +290,25 @@ public void testDerivedTableWithGroupBy() throws 
Exception {
                 query = "SELECT DISTINCT COLLECTDISTINCT(t.b) FROM (SELECT 
b_string b, a_string a FROM aTable GROUP BY a_string, b_string) AS t GROUP BY 
t.a";
    --- End diff --
    
    @JamesRTaylor Please ignore my previous (deleted) comment. I just realized 
that the server group-by has replaced tree map with hash map, which means an 
optimization I did for client group-by based on the assumption that the input 
is a sorted group-by is now invalid. I will fix this ASAP. And after the fix, 
the test case should fine, we should keep it as it is.


> Failing integration test in DerivedTableIT
> ------------------------------------------
>
>                 Key: PHOENIX-2257
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2257
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.6.0
>         Environment: Ubuntu and Fedora, 64-bit Java 8
>            Reporter: James Heather
>         Attachments: org.apache.phoenix.end2end.DerivedTableIT-output.txt
>
>
> {code}
> Failed tests:
>   DerivedTableIT.testDerivedTableWithGroupBy:320 expected:<['e']> but 
> was:<['b', 'c', 'e']>
>   DerivedTableIT.testDerivedTableWithGroupBy:320 expected:<['e']> but 
> was:<['b', 'c', 'e']>
> {code}
> This is on a freshly cloned copy of the repo, on the master branch.
> In the output, I get a couple of {{TableInfoMissingExceptions}}, which might 
> be related.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to