[
https://issues.apache.org/jira/browse/PHOENIX-2365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992476#comment-14992476
]
Cody Marcel commented on PHOENIX-2365:
--------------------------------------
This mostly looks really good Mujtaba.
Couple minor things. It looks like your path is hard coded there in the patch.
+hbasecp, stderr =
subprocess.Popen("/home/mchohan/Desktop/hbase/hbase-0.98.13-hadoop2/bin/hbase
classpath",
+ shell=True,
+ stdout=subprocess.PIPE,
+ stderr=subprocess.PIPE).communicate()
Also, this changes the way we package and run pherf. Should we also include doc
changes to the site page? Or do you think we should have a separate Jira for
that? I noticed it's out of date in other areas too.
> PHOENIX-2248 sub-task: Remove Pherf uber jar and create python scripts to
> execute from Phoenix bin directory
> ------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-2365
> URL: https://issues.apache.org/jira/browse/PHOENIX-2365
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Mujtaba Chohan
> Priority: Minor
> Attachments: PHOENIX-2248.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
