Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/126#discussion_r44723366
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/execute/PartialCommitIT.java ---
    @@ -259,10 +259,10 @@ private PhoenixConnection 
getConnectionWithTableOrderPreservingMutationState() t
             Connection con = driver.connect(url, new Properties());
             PhoenixConnection phxCon = new 
PhoenixConnection(con.unwrap(PhoenixConnection.class));
             final 
Map<TableRef,Map<ImmutableBytesPtr,MutationState.RowMutationState>> mutations = 
Maps.newTreeMap(new TableRefComparator());
    -        return new PhoenixConnection(phxCon) {
    +        return new PhoenixConnection(phxCon, null) {
    --- End diff --
    
    Never mind on this change - passing null is actually required here, though 
might be worth a code comment on why (because it forces the 
connection.newMutationState() to be used to create the MutationState).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to