[
https://issues.apache.org/jira/browse/PHOENIX-2412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004372#comment-15004372
]
Samarth Jain commented on PHOENIX-2412:
---------------------------------------
Thanks for the patch, [~ankit.singhal]. I tweaked your patch to get rid of
iterators member variable altogether. Ideally, double closing the iterators
shouldn't impact metrics. It should just result in a no-op. My changes in
PHOENIX-2357 will take care of that.
> Fix test failures due to use of priority queue for merge sort
> -------------------------------------------------------------
>
> Key: PHOENIX-2412
> URL: https://issues.apache.org/jira/browse/PHOENIX-2412
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: Ankit Singhal
> Attachments: PHOENIX-2412_v1.patch
>
>
> Looks like PHOENIX-2377 caused some test failures. Did you run all the unit
> tests (mvn verify) with your patch locally, [~ankit.singhal]?
> {code}
> Failed tests:
>
> PhoenixMetricsIT.testMetricsForUpsertSelectSameTable:615->assertMetricsAreSame:643->assertMetricsHaveSameValues:654
> Unequal values for metric MUTATION_BYTES expected:<5600> but was:<16240>
>
> PhoenixMetricsIT.testMetricsForUpsertSelectWithAutoCommit:462->assertMetricsAreSame:643->assertMetricsHaveSameValues:654
> Unequal values for metric MUTATION_BYTES expected:<5600> but was:<16240>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
