[
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004953#comment-15004953
]
ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/127#discussion_r44848578
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java ---
@@ -323,7 +324,8 @@ public MutationPlan compile(DeleteStatement delete)
throws SQLException {
// - read-only VIEW
// - transactional table with a connection having an SCN
// TODO: SchemaUtil.isReadOnly(PTable, connection)?
- if ( table.getType() == PTableType.VIEW &&
table.getViewType().isReadOnly() ) {
+ if ( ( table.getType() == PTableType.VIEW &&
table.getViewType().isReadOnly() )
+ || ( table.isTransactional() && connection.getSCN()
!= null ) ) {
--- End diff --
Let's create a new SQLExceptionCode and throw that rather than a
ReadOnlyTableException for the case of a connection specifying an SCN for a
transactional table.
> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
> Key: PHOENIX-1674
> URL: https://issues.apache.org/jira/browse/PHOENIX-1674
> Project: Phoenix
> Issue Type: Improvement
> Reporter: James Taylor
> Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one
> option for getting transaction support in Phoenix. Let's use this JIRA to
> discuss the way in which this could be integrated along with the pros and
> cons.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
