Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/127#discussion_r44852648
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -1498,30 +1542,61 @@ private PTable 
createTableInternal(CreateTableStatement statement, byte[][] spli
                 long clientTimeStamp = scn == null ? 
HConstants.LATEST_TIMESTAMP : scn;
                 boolean multiTenant = false;
                 boolean storeNulls = false;
    +            boolean transactional = false;
                 Integer saltBucketNum = null;
                 String defaultFamilyName = null;
                 boolean isImmutableRows = false;
                 List<PName> physicalNames = Collections.emptyList();
                 boolean addSaltColumn = false;
                 boolean rowKeyOrderOptimizable = true;
    +                   Long timestamp = null;
    --- End diff --
    
    Minor nit: check that your indenting is correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to