[ 
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005076#comment-15005076
 ] 

ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/127#discussion_r44853000
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java ---
    @@ -779,11 +784,20 @@ public void setValue(PColumn column, byte[] 
byteValue) {
             @Override
             public void delete() {
                 newMutations();
    -            Delete delete = new Delete(key);
    -            for (PColumnFamily colFamily : families) {
    -                   delete.addFamily(colFamily.getName().getBytes(), ts);
    +            if (PTableImpl.this.isTransactional()) {
    +                Put delete = new Put(key);
    --- End diff --
    
    Comment here that we're using the Tephra column family delete marker here 
to prevent the translation and early update on the server (similar to the 
storeNulls comment earlier).


> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
>                 Key: PHOENIX-1674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1674
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>              Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one 
> option for getting transaction support in Phoenix. Let's use this JIRA to 
> discuss the way in which this could be integrated along with the pros and 
> cons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to