[ 
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013037#comment-15013037
 ] 

ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------

Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/129#discussion_r45307901
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/TableRef.java ---
    @@ -111,6 +115,7 @@ public boolean equals(Object obj) {
             if (obj == null) return false;
             if (getClass() != obj.getClass()) return false;
             TableRef other = (TableRef)obj;
    +        // a null alias on either side should mean a wildcard and should 
not fail the equals check
             if ((alias == null && other.alias != null) || (alias != null && 
!alias.equals(other.alias))) return false;
             if 
(!table.getName().getString().equals(other.table.getName().getString())) return 
false;
    --- End diff --
    
    If table can be null, then you would need to guard against that here.


> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
>                 Key: PHOENIX-1674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1674
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>              Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one 
> option for getting transaction support in Phoenix. Let's use this JIRA to 
> discuss the way in which this could be integrated along with the pros and 
> cons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to