[
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023482#comment-15023482
]
ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/133#discussion_r45683372
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -1137,7 +1181,7 @@ public MutationState createIndex(CreateIndexStatement
statement, byte[][] splits
if (hbaseVersion <
PhoenixDatabaseMetaData.MUTABLE_SI_VERSION_THRESHOLD) {
throw new
SQLExceptionInfo.Builder(SQLExceptionCode.NO_MUTABLE_INDEXES).setTableName(indexTableName.getTableName()).build().buildException();
}
- if
(connection.getQueryServices().hasInvalidIndexConfiguration()) {
+ if
(connection.getQueryServices().hasInvalidIndexConfiguration() &&
!dataTable.isTransactional()) {
--- End diff --
I think hasInvalidIndexConfiguration() should be renamed to something like
isMutableIndexWALCodecInstalled(). The actual check happens on the server side.
Renaming this way makes it more explicit that the change has to do with mutable
secondary indexes and that if the table is transactional, then we don't care
about having the right codec in place on region servers.
> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
> Key: PHOENIX-1674
> URL: https://issues.apache.org/jira/browse/PHOENIX-1674
> Project: Phoenix
> Issue Type: Improvement
> Reporter: James Taylor
> Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one
> option for getting transaction support in Phoenix. Let's use this JIRA to
> discuss the way in which this could be integrated along with the pros and
> cons.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
